Fix annotations for overloaded functions (#1354) #5247
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: Build | |
| on: [push, pull_request] | |
| jobs: | |
| fetch-deps: | |
| name: Download original binaries | |
| uses: ./.github/workflows/legobin.yml | |
| build-current-toolchain: | |
| name: Current ${{ matrix.toolchain.name }} | |
| runs-on: windows-latest | |
| defaults: | |
| run: | |
| shell: ${{ matrix.toolchain.shell }} | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| toolchain: | |
| - { name: 'MSVC', shell: 'sh', setup-cmake: true, setup-ninja: true, setup-msvc: true } | |
| - { name: 'msys2 mingw32', shell: 'msys2 {0}', msystem: mingw32, msys-env: mingw-w64-i686, clang-tidy: true, werror: true } | |
| - { name: 'msys2 clang32', shell: 'msys2 {0}', msystem: clang32, msys-env: mingw-w64-clang-i686, clang-tidy: true, werror: true, no-dx5-libs: true } | |
| steps: | |
| - name: Set up MSYS2 | |
| if: ${{ !!matrix.toolchain.msystem }} | |
| uses: msys2/setup-msys2@v2 | |
| with: | |
| msystem: ${{ matrix.toolchain.msystem }} | |
| install: >- | |
| ${{ matrix.toolchain.msys-env }}-cc | |
| ${{ matrix.toolchain.msys-env }}-cmake | |
| ${{ matrix.toolchain.msys-env }}-ninja | |
| ${{ matrix.toolchain.msys-env }}-clang-tools-extra | |
| - name: Setup cmake | |
| if: matrix.toolchain.setup-cmake | |
| uses: jwlawson/actions-setup-cmake@v2 | |
| - name: Setup ninja | |
| if: matrix.toolchain.setup-ninja | |
| uses: ashutoshvarma/setup-ninja@master | |
| - name: Setup vcvars | |
| if: matrix.toolchain.setup-msvc | |
| uses: ilammy/msvc-dev-cmd@v1 | |
| with: | |
| arch: amd64_x86 # Use the 64-bit x64-native cross tools to build 32-bit x86 code | |
| - uses: actions/checkout@v4 | |
| - name: Build | |
| run: | | |
| cmake -S . -B build -GNinja \ | |
| -DCMAKE_BUILD_TYPE=Debug \ | |
| -DISLE_USE_DX5_LIBS=${{ !matrix.toolchain.no-dx5-libs }} \ | |
| -DENABLE_CLANG_TIDY=${{ !!matrix.toolchain.clang-tidy }} \ | |
| -DISLE_WERROR=${{ !!matrix.toolchain.werror }} \ | |
| -Werror=dev | |
| cmake --build build -- -k0 | |
| build: | |
| name: 'MSVC 4.20' | |
| runs-on: windows-latest | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - uses: actions/checkout@v4 | |
| with: | |
| repository: itsmattkc/msvc420 | |
| path: msvc420 | |
| - name: Setup cmake | |
| uses: jwlawson/actions-setup-cmake@v2 | |
| with: | |
| # Use minimum supported version | |
| cmake-version: '3.15.x' | |
| - name: Patch MSVC 4.2 | |
| run: | | |
| tools/patch_c2.py msvc420/bin/C2.EXE | |
| - name: Build | |
| shell: cmd | |
| run: | | |
| call .\msvc420\bin\VCVARS32.BAT x86 | |
| cmake -B build -DCMAKE_BUILD_TYPE=RelWithDebInfo -G "NMake Makefiles" | |
| cmake --build build | |
| - name: Upload Artifact | |
| uses: actions/upload-artifact@main | |
| with: | |
| name: Win32 | |
| path: | | |
| build/CONFIG.EXE | |
| build/CONFIG.PDB | |
| build/ISLE.EXE | |
| build/ISLE.PDB | |
| build/LEGO1.DLL | |
| build/LEGO1.PDB | |
| compare: | |
| name: Compare with master | |
| needs: [build, fetch-deps] | |
| runs-on: windows-latest | |
| steps: | |
| - uses: actions/checkout@main | |
| - uses: actions/setup-python@v5 | |
| with: | |
| python-version: '3.12' | |
| - uses: actions/download-artifact@main | |
| with: | |
| name: Win32 | |
| path: build | |
| - name: Restore cached original binaries | |
| id: cache-original-binaries | |
| uses: actions/cache/restore@v4 | |
| with: | |
| enableCrossOsArchive: true | |
| path: legobin | |
| key: legobin | |
| - name: Install python packages | |
| shell: bash | |
| run: | | |
| pip install -r tools/requirements.txt | |
| - name: Detect binaries | |
| run: | | |
| reccmp-project detect --what original --search-path legobin | |
| reccmp-project detect --what recompiled --search-path build | |
| - name: Summarize Accuracy | |
| shell: bash | |
| run: | | |
| reccmp-reccmp -S CONFIGPROGRESS.SVG --svg-icon assets/config.png --target CONFIG --json CONFIGPROGRESS.json | |
| reccmp-reccmp -S ISLEPROGRESS.SVG --svg-icon assets/isle.png --target ISLE --json ISLEPROGRESS.json | |
| reccmp-reccmp -S LEGO1PROGRESS.SVG --svg-icon assets/lego1.png --target LEGO1 --json LEGO1PROGRESS.json | |
| - name: Compare Accuracy With Current Master | |
| shell: bash | |
| env: | |
| RELEASE_URL: https://github.com/isledecomp/isle/releases/download/continuous | |
| run: | | |
| # Download the current master state | |
| curl -fLSs -o CONFIGPROGRESS-old.json $RELEASE_URL/CONFIGPROGRESS.json || echo "" >CONFIGPROGRESS-old.json | |
| curl -fLSs -o ISLEPROGRESS-old.json $RELEASE_URL/ISLEPROGRESS.json || echo "" >ISLEPROGRESS-old.json | |
| curl -fLSs -o LEGO1PROGRESS-old.json $RELEASE_URL/LEGO1PROGRESS.json || echo "" >LEGO1PROGRESS-old.json | |
| # Compare with current master | |
| reccmp-reccmp --target CONFIG --diff CONFIGPROGRESS-old.json || echo "Current master not found" | |
| reccmp-reccmp --target ISLE --diff ISLEPROGRESS-old.json || echo "Current master not found" | |
| reccmp-reccmp --target LEGO1 --diff LEGO1PROGRESS-old.json || echo "Current master not found" | |
| - name: Test Exports | |
| shell: bash | |
| run: | | |
| reccmp-verexp --target LEGO1 | |
| - name: Check Vtables | |
| shell: bash | |
| run: | | |
| reccmp-vtable --target CONFIG | |
| reccmp-vtable --target ISLE | |
| reccmp-vtable --target LEGO1 | |
| - name: Check Variables | |
| shell: bash | |
| run: | | |
| reccmp-datacmp --target CONFIG | |
| reccmp-datacmp --target ISLE | |
| reccmp-datacmp --target LEGO1 | |
| - name: Upload Artifact | |
| uses: actions/upload-artifact@main | |
| with: | |
| name: Accuracy Report | |
| path: | | |
| CONFIGPROGRESS.* | |
| ISLEPROGRESS.* | |
| LEGO1PROGRESS.* | |
| upload: | |
| name: Upload artifacts | |
| needs: [build, compare] | |
| runs-on: ubuntu-latest | |
| if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/master' && github.repository == 'isledecomp/isle' }} | |
| steps: | |
| - uses: actions/checkout@v4 | |
| with: | |
| repository: probonopd/uploadtool | |
| - uses: actions/download-artifact@main | |
| with: | |
| name: Win32 | |
| path: build | |
| - uses: actions/download-artifact@main | |
| with: | |
| name: Accuracy Report | |
| - name: Upload Continuous Release | |
| env: | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| UPLOAD_KEY: ${{ secrets.UPLOAD_KEY }} | |
| run: | | |
| ./upload.sh \ | |
| build/CONFIG.EXE \ | |
| build/ISLE.EXE \ | |
| build/LEGO1.DLL \ | |
| CONFIGPROGRESS.* \ | |
| ISLEPROGRESS.* \ | |
| LEGO1PROGRESS.* | |
| curl -X POST -F key=$UPLOAD_KEY -F '[email protected]' https://legoisland.org/progress/ | |
| curl -X POST -F key=$UPLOAD_KEY -F '[email protected]' https://legoisland.org/progress/ | |
| curl -X POST -F key=$UPLOAD_KEY -F '[email protected]' https://legoisland.org/progress/ |