Skip to content

Commit

Permalink
Enable live logging for non-parallel pytest runs
Browse files Browse the repository at this point in the history
This provides incremental output when test is running _without xdist_,
just like the old runner did.

With xdist the live output is not available, I believe because of
pytest-dev/pytest-xdist#402
pytest-dev/pytest-xdist#883 might help with
that, but I'm not going to hold my breath until it is available on
distros we use.
  • Loading branch information
pspacek authored and nicki-krizek committed Mar 28, 2023
1 parent 7f3a272 commit 5907144
Showing 1 changed file with 33 additions and 20 deletions.
53 changes: 33 additions & 20 deletions bin/tests/system/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,21 @@ def control_port():

# ---------------------- Module initialization ---------------------------

def avoid_duplicated_logs():
"""
Remove direct root logger output to file descriptors.
This default is causing duplicates because all our messages go through
regular logging as well and are thus displayed twice.
"""
todel = []
for handler in logging.root.handlers:
if handler.__class__ == logging.StreamHandler:
# Beware: As for pytest 7.2.2, LiveLogging and LogCapture
# handlers inherit from logging.StreamHandler
todel.append(handler)
for handler in todel:
logging.root.handlers.remove(handler)

def parse_env(env_text):
"""Parse the POSIX env format into Python dictionary."""
out = {}
Expand Down Expand Up @@ -282,6 +297,7 @@ def system_test_name(request):
@pytest.fixture(scope="module")
def logger(system_test_name):
"""Logging facility specific to this test."""
avoid_duplicated_logs()
return logging.getLogger(system_test_name)

@pytest.fixture(scope="module")
Expand Down Expand Up @@ -377,29 +393,26 @@ def _run_script( # pylint: disable=too-many-arguments
raise FileNotFoundError(f"script {script} not found in {cwd}")
logger.debug("running script: %s %s %s", interpreter, script, " ".join(args))
logger.debug(" workdir: %s", cwd)
stdout = b""
returncode = 1
try:
proc = subprocess.run(
[interpreter, script] + args,
env=env,
check=True,
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
)
except subprocess.CalledProcessError as exc:
stdout = exc.stdout
returncode = exc.returncode
raise exc
else:
stdout = proc.stdout

cmd = [interpreter, script] + args
with subprocess.Popen(
cmd,
env=env,
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
bufsize=1,
universal_newlines=True,
errors='backslashreplace'
) as proc:
if proc.stdout:
for line in proc.stdout:
logger.info(" %s", line.rstrip('\n'))
proc.communicate()
returncode = proc.returncode
finally:
if stdout:
for line in stdout.decode().splitlines():
logger.debug(" %s", line)
if returncode:
raise subprocess.CalledProcessError(returncode, cmd)
logger.debug(" exited with %d", returncode)
return proc

@pytest.fixture(scope="module")
def shell(env, system_test_dir, logger):
Expand Down

0 comments on commit 5907144

Please sign in to comment.