Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Camera Benchmark Tool and Allow Correct Unprojection of distance_to_camera depth image #976
Add Camera Benchmark Tool and Allow Correct Unprojection of distance_to_camera depth image #976
Changes from 47 commits
7391a79
e3d2889
bc8b72a
6e5e743
bcd2acf
0c79677
247add6
95b744e
44875e2
9c66b6c
86483cf
21819e1
134ba01
ba62753
1995022
08624d9
216ad85
63d47a6
8c3ccb3
9fd0aa4
b3d9103
c4b627e
2ad7835
c0094b7
4f7db7f
1187c6c
6ebf5ff
24a184a
f3932df
cc9224a
ebc2baf
1c1b41c
69b5b79
773ef65
18aa427
3065c80
3c8e43f
a3c410a
a44f15d
c47ebb5
97ab5a6
f001216
9bef60c
f51a1cc
3649952
712e3bd
e98514f
17c74f3
4f68566
3e749e6
fbfb191
5ec0967
0e62b8b
eb0de81
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: You need to update BOTH extension.toml and CHANGELOG.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow google doc-style. The first line here is a one-line sumary. Everything else moves to a new para.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r"""
is only used when you have math equations. In all other cases, please resort to double ticks.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is a math util, any mention of replicator does not make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please always add a docstring for a test so the description also is visible when you run the test.