Some small fixes in config and tests (4-3-stable) #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops - renamed the |
|
Awaiting test results. |
|
Tests passed after fixing all the silly mistakes. :) |
|
Squash to taste. |
alanking
force-pushed
the
misc-fixes.43s
branch
from
fbbbdb7 to
dad351e
Compare
|
Squashed |
wait_for_empty_queue now allows the caller to specify a timeout in seconds as well as a function to run when a timeout occurs. If None is given for the function to run when a timeout occurs, the function raises a TimeoutError Exception. Existing uses of this function pass self.fail() to run on timeout with a brief message explaining the failure.
alanking
force-pushed
the
misc-fixes.43s
branch
from
dad351e to
404c9d7
Compare
|
#'d. Mergin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In service of #246 (only fixes test never finishing)
Addresses #178
Addresses #278
Still seeing occasional failure of the test as described in #246 but this at least makes it so that the test can fail after a while. Will continue to investigate that.
Tests passed.