[162, 163] Fix build and test hooks (main) #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korydraughn
reviewed
Aug 16, 2024
|
Tests pass. |
|
Running tests for EL8 and EL9. If those succeed, then this will be ready for merging. will report back once those tests complete. |
|
Just realized this is for the main branch. We need this to happen on 4-3-stable. Postponing testing until that's done. |
|
@FifthPotato - Let's go ahead and cherry-pick this to 4-3-stable and then we'll merge this after or at around the same time. |
korydraughn
reviewed
Aug 19, 2024
SwooshyCueb
suggested changes
Aug 19, 2024
|
@FifthPotato Please address the review comments and leave a comment once completed. |
FifthPotato
force-pushed
the
testing-fixes.m
branch
from
9725686 to
aa16f58
Compare
|
Updated. Tests still pass. |
alanking
approved these changes
Aug 21, 2024
FifthPotato
force-pushed
the
testing-fixes.m
branch
from
aa16f58 to
a0deee0
Compare
|
Octothorpe'd. |
|
For future PRs, let's keep spaces out of the issue number list (in square brackets) for commit messages. For example, commit messages should look like the following: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not install unittest-xml-reporting==1.14.0
Update versions of externals packages in build hook