Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an intentionally failing task which implicates individual files which failed to sync #296

Open
alanking opened this issue Oct 7, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@alanking
Copy link
Collaborator

alanking commented Oct 7, 2024

When files fail to sync, it will cause the rest of the files in the chunk for that task to fail as well. This could be done simply by allowing the rest of the files in the task to continue syncing.

The failed sync(s) could cause that sync task to fail, which would cause the whole thing to be retried later or require the caller to audit the files in the chunk against objects which successfully synced to the destination collection.

Alternatively, each file which fails to sync could be placed in a new task which intentionally fails but contains information about the file which failed to sync so that it can be retried or at least more easily understood as to what failed.

@korydraughn
Copy link
Contributor

I'm assuming the files which follow the failure will be allowed to proceed, correct?

@alanking
Copy link
Collaborator Author

alanking commented Oct 7, 2024

Yes, the failure should be caught and then the task should continue processing its list of files.

@korydraughn
Copy link
Contributor

Good.

@alanking
Copy link
Collaborator Author

alanking commented Oct 8, 2024

Possible duplicate of #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants