Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for "PEP" event_handler methods to abort operation for a single path #184

Open
alanking opened this issue Nov 11, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@alanking
Copy link
Collaborator

alanking commented Nov 11, 2022

The user should be allowed to abort the operation for any reason and define next steps for the ingest framework as part of the event_handler "PEP" implementations. Currently, if an Exception is raised from an event_handler method like pre_data_obj_create, the entire file chunk will fail and be placed in the retry queue.

This could take many forms. Our initial idea was to raise a custom Exception which contains information for the plugin framework for how to handle the file which is being aborted. The most obvious use case to us would be to create a new task with just that file that is immediately placed on the fail queue or the retry queue, and then the framework would continue to ingest the rest of the files in the current task.

This would serve as an alternative implementation for options such as --exclude_file_name which is not currently possible for this framework and may have other applications which we do not know about.

@alanking alanking added the enhancement New feature or request label Nov 11, 2022
@d-w-moore
Copy link
Contributor

This would serve as an alternative implementation for options such as --exclude_file_name which is not currently possible for this framework

What currently prevents --exclude_file_name from working in the ingest tool?

@alanking
Copy link
Collaborator Author

@d-w-moore - Please see #182

@alanking
Copy link
Collaborator Author

alanking commented Oct 8, 2024

This could take many forms. Our initial idea was to raise a custom Exception which contains information for the plugin framework for how to handle the file which is being aborted. The most obvious use case to us would be to create a new task with just that file that is immediately placed on the fail queue or the retry queue, and then the framework would continue to ingest the rest of the files in the current task.

This sounds a lot like the thing described in #296...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants