Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LLVMGPU] Add PartialReduction tiling to LLVMGPUVectorDistribution pipeline #19711

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[LLVMGPU] Add PartialReduction tiling to LLVMGPUVectorDistribution pipeline #19711

wants to merge 1 commit into from
+110 −0

Conversation

Groverkss
Copy link
Contributor

Now that GPUApplyTilingLevel supports PartialReduction tiling, we can enable it for LLVMGPUVectorDistribute pipeline. This path is used for attention warp reduction style codegen.

@Groverkss Groverkss requested a review from manupak January 15, 2025 17:52
@manupak
Copy link
Contributor

manupak commented Jan 15, 2025

Im trying to understand why we cant use the subgroup basis on reduction dims to convey this information?
Wont it naturally split the reduction into subgroups?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaheshRavishankar MaheshRavishankar Awaiting requested review from MaheshRavishankar MaheshRavishankar is a code owner

@qedawkins qedawkins Awaiting requested review from qedawkins qedawkins is a code owner

@kuhar kuhar Awaiting requested review from kuhar kuhar is a code owner

@manupak manupak Awaiting requested review from manupak

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Groverkss @manupak