[VectorDistribution] Allow f16 vector.multi_reduction distribution #19710
+12
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhar
reviewed
Jan 15, 2025
I don't think this test actually checks if gpu.subgroup_reduce lowers properly. So we could really throw anything to it. We are just relying on gpu.subgroup_reduce tests to check if int8 works for now. I'd prefer not adding it right now because we don't really use these lowerings for anything other than attention where this reduction will either be fp16/fp32. As we move the warp reduction pipeline, i'll add more tests. |
kuhar
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The elemBitwidth == maxBitsPerShuffle condition was added when we did not have packed shuffle implemented. Since we now go through gpu.subgroup_reduce, which implements packed shuffle, we only need to check if elemBitwidth <= maxBitsPerShuffle.