Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ValueBoundsOpInterface on HAL ID/count ops, util.assume.int #19676

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement ValueBoundsOpInterface on HAL ID/count ops, util.assume.int #19676

wants to merge 1 commit into from
+126 −0

Conversation

krzysz00
Copy link
Contributor

Add a model of ValueBoundsOpInterface (the one used for reasoning
about affine maps and loops) to the HAL ID ops and util.assume.int to
improve both loop invariant code motion and, in the future,
single-iteration loop removal.

@krzysz00
Copy link
Contributor Author

PR stack:

This was referenced Jan 11, 2025
Open
Open
@krzysz00 krzysz00 requested review from hanhanW and qedawkins January 16, 2025 22:27
qedawkins
qedawkins reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@qedawkins qedawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation LGTM. Are the LLVM changes landed and just waiting on integrate? Also is there a way to test this?

@krzysz00
Copy link
Contributor Author

Yeah, the LlVM changes are just holding on integrete ... and I can add a test, good catch

@krzysz00
Copy link
Contributor Author

@qedawkins The tests are up in #19678 since the only upstream pass we can use for testing is an upstream test pass and I don't think we routinely build those

qedawkins
qedawkins approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@qedawkins qedawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we don't want to build those upstream test passes. This LGTM after integrate. You could also land the tests in #19678 here instead

@krzysz00
Implement ValueBoundsOpInterface on HAL ID/count ops, util.assume.int
6c59ac1 
Add a model of ValueBoundsOpInterface (the one used for reasoning
about affine maps and loops) to the HAL ID ops and util.assume.int to
improve both loop invariant code motion and, in the future,
single-iteration loop removal.
@krzysz00 krzysz00 force-pushed the users/krzysz00/value-bound-hal-ops branch from 6cdfa93 to 6c59ac1 Compare January 18, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qedawkins qedawkins qedawkins approved these changes

@MaheshRavishankar MaheshRavishankar Awaiting requested review from MaheshRavishankar MaheshRavishankar is a code owner

@benvanik benvanik Awaiting requested review from benvanik benvanik is a code owner

@hanhanW hanhanW Awaiting requested review from hanhanW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzysz00 @qedawkins