Reapply "[Flow] Convert from tensor.cast to flow.tensor.reshape" #18351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvedhmeshram
requested review from
hanhanW,
MaheshRavishankar and
IanWood1
as code owners
nirvedhmeshram
force-pushed
the
users/nirvedhmeshram/reland_tensorcast
branch
from
7f85e69
to
bf047c5
Compare
nirvedhmeshram
changed the title
nirvedhmeshram
force-pushed
the
users/nirvedhmeshram/reland_tensorcast
branch
5 times, most recently
from
c7fa345
to
9e9f10d
Compare
MaheshRavishankar
approved these changes
Aug 26, 2024
nirvedhmeshram
force-pushed
the
users/nirvedhmeshram/reland_tensorcast
branch
from
9e9f10d
to
c51b165
Compare
nirvedhmeshram
force-pushed
the
users/nirvedhmeshram/reland_tensorcast
branch
from
c51b165
to
dcc5e11
Compare
|
Looks like there is another backend failure is RISCV for a conv test, after discussing with @MaheshRavishankar , we decided to disable this test as well. |
nirvedhmeshram
force-pushed
the
users/nirvedhmeshram/reland_tensorcast
branch
from
bd41466
to
8c8e02c
Compare
|
The |
IanWood1
added a commit
to IanWood1/iree
that referenced
this pull request
Oct 14, 2024
…ape" (iree-org#18351)" This reverts commit d2e74cd. Signed-off-by: Ian Wood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit relands the canonicalization that was reverted due to an ARM issue llvm/llvm-project#105869 (and more recently RISCV issue).
The second commit disables the failing tests for the respective backend.