Misc type annotations #1294
Merged
Misc type annotations #1294
+12
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from ipython#1272
minrk
reviewed
Nov 14, 2024
ipykernel/kernelapp.py
Outdated
| control_thread = Any() | ||
| shell_channel_thread = Any() | ||
|
|
||
| iopub_thread: BaseThread |
There was a problem hiding this comment.
I think these still need to be defined as traits, e.g. : BaseThread = Any() or perhaps even Instance(BaseThread, allow_none=True).
There was a problem hiding this comment.
I think that will need a # type: ignore[assignment] as well, or mypy will be unhappy
|
Updated, and fixed the corresponding error shown by mypy. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #1272