Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deployment of topologies containing 'none' devices, remove ghosts from links #1659

Closed
wants to merge 10 commits into from

Conversation

jbemmel
Copy link
Collaborator

@jbemmel jbemmel commented Dec 17, 2024

Context: #1657

none devices are useful for validation, but they could also be used to deploy scaled deployments representing 100s of nodes. This PR treats 'none' devices as 'unmanaged' for the purpose of netlab up

  • Modify the node.clone plugin to merge settings from existing nodes, to allow selective override of attributes.
    For example: model a switch with 32 servers, but launch only 2 of those as 'linux' containers

  • Fix netlab up for clab topologies containing unmanaged nodes (the links section would contain semi-connected entries), by removing ghosts from links as well.
    Test: netlab up topology/input/unmanaged-device.yml -p clab -v

Handling unmanaged devices could possibly be done in different ways, without removing them from the links. libvirt deployment does succeed. For example, we could modify clab.j2 to use Containerlab dummy devices (https://containerlab.dev/manual/topo-def-file/#dummy)

The current output in https://github.com/ipspace/netlab/blob/dev/tests/topology/expected/unmanaged-device.yml is invalid, as there is a link that refers to a non-existent node 'external'

Copy link
Owner

@ipspace ipspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your idea to use a hard-coded bridge name won't work with the multilab plugin. Also, the integration tests do not belong to the "initial device configuration" suite. Move them into a new directory (if needed) of the "platform-integration" tree.

netsim/augment/nodes.py Outdated Show resolved Hide resolved
netsim/extra/node.clone/plugin.py Outdated Show resolved Hide resolved
@ipspace ipspace marked this pull request as draft December 23, 2024 06:21
@jbemmel jbemmel marked this pull request as ready for review January 2, 2025 12:27
@jbemmel
Copy link
Collaborator Author

jbemmel commented Jan 2, 2025

Closing as a similar effect can be achieved by using unmanaged nodes

@jbemmel jbemmel closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants