lag: Disallow direct IP addressing on MLAG interfaces, not supported …

…on most (all?) platforms
ipspace · Dec 31, 2024 · 70f9c00 · 70f9c00
1 parent 07d612c
commit 70f9c00
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/netsim/modules/lag.py b/netsim/modules/lag.py
@@ -392,8 +392,12 @@ def node_post_transform(self, node: Box, topology: Box) -> None:
           log.error(f'Node {node.name} does not support passive LACP configured on interface {i.ifname}',
             category=log.IncorrectAttr,
             module='lag')
-        if i.lag.get('mlag',False) is True:
+        if i.lag.get('_mlag',False) is True:
           uses_mlag = True
+          if 'ipv4' in i or 'ipv6' in i:
+            log.error(f'Node {node.name}: IP address directly on MLAG interface {i.ifname} is not supported, use a VLAN instead',
+              category=log.IncorrectAttr,
+              module='lag')
 
     if uses_mlag and not has_peerlink:
       log.error(f'Node {node.name} uses MLAG but has no peerlink (lag with {PEERLINK_ID_ATT}) configured',