Skip to content

Commit

Permalink
Import orphan instances as quick-fix for issue TokTok#7.
Browse files Browse the repository at this point in the history
Ideally we would not have orphan instances. PR TokTok#5 introduced them. See
https://stackoverflow.com/questions/3079537/orphaned-instances-in-haskell
for some reasons why we want to avoid them.
  • Loading branch information
iphydf committed Dec 18, 2016
1 parent 8e44758 commit bf32e64
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/Network/MessagePack/Rpc.hs
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ import qualified Network.MessagePack.Interface.Internal as I
import qualified Network.MessagePack.Types.Client as Client
import qualified Network.MessagePack.Types.Server as Server

-- Import orphan instances for RpcType and IsReturnType.
-- TODO(SX91): Avoid orphan instances. See issue #7.
import Network.MessagePack.Client.Basic ()
import Network.MessagePack.Server.Basic ()


class RpcService rpc where
type ClientMonad rpc :: * -> *
Expand Down

0 comments on commit bf32e64

Please sign in to comment.