Skip to content

Commit

Permalink
chore: Update CI with fixes (#604)
Browse files Browse the repository at this point in the history
* Remove old volta stuff

* chore: Update CI to latest actions

* add node 16 back
  • Loading branch information
markemer authored Jun 12, 2024
1 parent b60ec8d commit ba68dad
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 15 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x, 18.x]
node-version: [16.x, 18.x, 20.x]
steps:
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- uses: actions/checkout@v1
- uses: actions/checkout@v4
- name: npm install, build, and test
env:
CI: true
Expand Down
9 changes: 3 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 1 addition & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,5 @@
"@xmldom/xmldom": "0.7.7"
}
}
},
"volta": {
"node": "16.13.2",
"npm": "8.3.0"
}
}
}
2 changes: 1 addition & 1 deletion src/platforms/pwa/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ export class PwaAssetGenerator extends AssetGenerator {
for (const icon of icons) {
if (await pathExists(join(pwaDir, icon.src))) {
const exists = !!pwaAssets.find(({ template: { width, height } }) => {
return `${width}x${height}` === icon.sizes
return `${width}x${height}` === icon.sizes;
});
if (!exists) {
rmSync(join(pwaDir, icon.src));
Expand Down

0 comments on commit ba68dad

Please sign in to comment.