Tidy repo (#91)

* Tidy repo

* Use versioned action

.github/workflows/publish-container.yml

@@ -10,7 +10,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Install PHP
-        uses: shivammathur/setup-php@master
+        uses: shivammathur/setup-php@v2
         with:
           php-version: '8.3'
       - name: Install dependencies

.github/workflows/push.yml

@@ -10,7 +10,7 @@ jobs:
     steps:
     - uses: actions/checkout@v4
     - name: Install PHP
-      uses: shivammathur/setup-php@master
+      uses: shivammathur/setup-php@v2
       with:
         php-version: ${{ matrix.php-version }}
     - name: Install dependencies
@@ -27,7 +27,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Install PHP
-        uses: shivammathur/setup-php@master
+        uses: shivammathur/setup-php@v2
         with:
           php-version: '8.3'
       - name: Install dependencies
@@ -39,7 +39,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Install PHP
-        uses: shivammathur/setup-php@master
+        uses: shivammathur/setup-php@v2
         with:
           php-version: '8.3'
       - name: Install dependencies

.php-cs-fixer.dist.php

@@ -2,8 +2,11 @@
 
 declare(strict_types=1);
 
-$finder = PhpCsFixer\Finder::create()
-    ->in(['src', 'tests'])
+$finder = (new PhpCsFixer\Finder())
+    ->in(__DIR__)
+    ->exclude([
+        'node_modules',
+    ])
 ;
 
 $config = new PhpCsFixer\Config();

README.md

@@ -199,14 +199,17 @@ _Note: Don't set the schedule frequency to high to not overload their website_
 
 ## Run (serverless)
 
-Termin can also be run as a serverless application. Configure the application like you would normally.
+Termin can also be run as a serverless application. Configure the application like you would like any other way.
 
-Then configure your environment with [serverless tooling][9].
+Install serverless toolchain:
 
 ```bash
 npm install
 ```
 
+Then configure your environment with [serverless tooling][9].
+
+
 And finally deploy:
 
 ```bash

app.php

@@ -1,13 +1,15 @@
 <?php
 
+declare(strict_types=1);
+
 use Inverse\Termin\Config\ConfigParser;
 use Inverse\Termin\Container;
 use Symfony\Component\Yaml\Yaml;
 
 require __DIR__.'/vendor/autoload.php';
 
 $configLoader = new ConfigParser();
-$config = $configLoader->parse(Yaml::parseFile(__DIR__ . '/config.yml'));
+$config = $configLoader->parse(Yaml::parseFile(__DIR__.'/config.yml'));
 
 $container = new Container($config);
 

phpstan.neon.dist

@@ -4,5 +4,5 @@ parameters:
 		- %currentWorkingDirectory%/tests
 	excludePaths:
 		- %currentWorkingDirectory%/src/Container.php
-	level: 7
+	level: 8
 	checkMissingIterableValueType: false

serverless.php

@@ -1,27 +1,28 @@
 <?php
-
+
+declare(strict_types=1);
+
 use Bref\Context\Context;
 use Inverse\Termin\Config\ConfigParser;
 use Inverse\Termin\Container;
 use Symfony\Component\Yaml\Yaml;
 
 require __DIR__.'/vendor/autoload.php';
 
-
-class Handler implements \Bref\Event\Handler
+class Handler implements Bref\Event\Handler
 {
     public function handle($event, Context $context)
     {
         $configLoader = new ConfigParser();
-        $config = $configLoader->parse(Yaml::parseFile(__DIR__ . '/config.yml'));
-        
+        $config = $configLoader->parse(Yaml::parseFile(__DIR__.'/config.yml'));
+
         $container = new Container($config, 'serverless');
-        
+
         $termin = $container->getTermin();
         $termin->run($config->getSites());
-        
+
         return 'OK';
     }
 }
- 
+
 return new Handler();

tests/Config/ConfigParserTest.php

@@ -89,7 +89,7 @@ public function testParseValid(): void
         $config = $this->configParser->parse($this->getBasicConfig());
 
         self::assertCount(1, $config->getSites());
-        self::assertEquals($config->getSites()[0]->getLabel(), 'Important');
+        self::assertEquals('Important', $config->getSites()[0]->getLabel());
         self::assertEquals(['param_1' => 'value_1'], $config->getSites()[0]->getParams());
         self::assertFalse($config->isAllowMultipleNotifications());
         self::assertNull($config->getTelegram());
@@ -120,8 +120,13 @@ public function testParseNtfyValidDefaultServer(): void
             ],
         ]);
 
-        self::assertEquals($config->getNtfy()->getServer(), Ntfy::DEFAULT_SERVER);
-        self::assertEquals($config->getNtfy()->getTopic(), 'termin_fun');
+        $ntfy = $config->getNtfy();
+        if (null === $ntfy) {
+            self::fail('Ntfy config must not be null');
+        }
+
+        self::assertEquals(Ntfy::DEFAULT_SERVER, $ntfy->getServer());
+        self::assertEquals('termin_fun', $ntfy->getTopic());
     }
 
     public function testParseNtfyValid(): void
@@ -133,8 +138,13 @@ public function testParseNtfyValid(): void
             ],
         ]);
 
-        self::assertEquals($config->getNtfy()->getServer(), 'https://my-server.com');
-        self::assertEquals($config->getNtfy()->getTopic(), 'termin_fun');
+        $ntfy = $config->getNtfy();
+        if (null === $ntfy) {
+            self::fail('Ntfy config must not be null');
+        }
+
+        self::assertEquals('https://my-server.com', $ntfy->getServer());
+        self::assertEquals('termin_fun', $ntfy->getTopic());
     }
 
     public function testParseTelegramEmpty(): void
@@ -202,8 +212,13 @@ public function testParseTelegramValid(): void
             ],
         ]);
 
-        self::assertEquals($config->getTelegram()->getApiKey(), 'api');
-        self::assertEquals($config->getTelegram()->getChatId(), 1);
+        $telegram = $config->getTelegram();
+        if (null === $telegram) {
+            self::fail('Telegram config must not be null');
+        }
+
+        self::assertEquals('api', $telegram->getApiKey());
+        self::assertEquals(1, $telegram->getChatId());
     }
 
     public function testParsePushbulletEmpty(): void
@@ -235,7 +250,12 @@ public function testParsePushbulletValid(): void
             ],
         ]);
 
-        self::assertEquals($config->getPushbullet()->getApiToken(), 'token');
+        $pushbullet = $config->getPushbullet();
+        if (null === $pushbullet) {
+            self::fail('Pushbullet config must not be null');
+        }
+
+        self::assertEquals('token', $pushbullet->getApiToken());
     }
 
     public function testParseRulesNotArray(): void