remove upper limit #174
Draft
remove upper limit #174
+200
−183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utnapischtim
force-pushed
the
remove-upper-limit
branch
4 times, most recently
from
ae5726d
to
b9b8b3d
Compare
utnapischtim
force-pushed
the
remove-upper-limit
branch
2 times, most recently
from
1b20e07
to
9d87e8b
Compare
* it is not working anymore with localproxy and it seams not necessary
* use the proxy file instead of creating the _db variable in both files * this removes a DeprecationWarning from flask-sqlalchemy, which states that the support of the use '.db' will be removed
* the error indicates that db.init_app is not called, but it is and it works in other contexts. It may that the `db = invenio_db = shared.db` line in conftest.py is not working as expected anymore. The only found solution is this. The drawback is, if that is the only solution it has to be done also in the other packages which are using this function. With the default value it is backward compatible but as the tests indicates it may not work without adding the db parameter to the function call
* added D202, pydocstyle and black do not habe the same opinion * remove warning by using StringEncryptedType instead of EncryptedType. This removes a warning and there is further a notice in the code that the base type of EncryptedType will change in the future and it is better to replace it with StringEncryptedType
utnapischtim
force-pushed
the
remove-upper-limit
branch
from
9d87e8b
to
e4f78e6
Compare
* this change makes it possible to import the MockEntryPoints from an independend file. this class is used in two tests but defined in one of them. placing it into a separated file makes it independent.
* this leads to the problem that the program couldn't connect to the database
* apply new correct return values to cli calls * refactor code * remove unused code
* added some explanation comments * apply db.session.query over Model.query syntax
* sqlalchemy.exc.ArgumentError: Column expression, FROM clause, or other columns clause element expected, got [<sqlalchemy.sql.elements.BinaryExpression object at 0x7fa3a0>, <sqlalchemy.sql.elements.BinaryExpression object at 0x7fa3ad246690>]. Did you mean to say select(<sqlalchemy.sql.elements.BinaryExpression object at 0x7fa3b1145c10>, <sqly.sql.elements.BinaryExpression object at 0x7fa3ad246690>) don't give the array to the select but give the elements to the select method * AttributeError: 'Engine' object has no attribute 'execute' -> change to session * TypeError: scoped_session.execute() got an unexpected keyword argument 'a' -> change to dict
utnapischtim
force-pushed
the
remove-upper-limit
branch
from
e4f78e6
to
cc7b450
Compare
* the rollback should only rollback whats in that savepoint. using session.begin_nested creates a subtransaction which can then rolledback
utnapischtim
force-pushed
the
remove-upper-limit
branch
from
d889109
to
f00e461
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE
worked locally with flask>=3.0.0, werkzeug>=3.0.0, flask-alemib>=3.0.0. further updated invenio-base is necessary (otherwise flask and werkzeug couldn't be updated)
ATTENTION
tests are not independent. if tests in
test_db.pyfail tests intest_versioningfail too although they would work without problemsDISCUSSION
some fixes should be discussed so review carfully
KNOWN issues