Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add media download functionality to exportActorProfile #6

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

0marSalah
Copy link
Collaborator

add media/ folder to exported tarball file

media files after extracting path => media/{media.id}.{file_extension}

@0marSalah 0marSalah self-assigned this Dec 5, 2024
src/index.ts Outdated
}

try {
const response = await fetch(mediaUrl)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move the downloadMedia logic to Hollo (instead of the wallet export lib). So, Hollo would download the media and pass in the streams to wallet export.

Copy link
Member

@dmitrizagidulin dmitrizagidulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dmitrizagidulin dmitrizagidulin merged commit 2ed6ff0 into main Dec 12, 2024
2 checks passed
@dmitrizagidulin dmitrizagidulin deleted the add-export-media branch December 12, 2024 23:07
@dmitrizagidulin
Copy link
Member

Published on NPM as v0.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants