Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better xml parsing #157

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Better xml parsing #157

merged 4 commits into from
Nov 12, 2024

Conversation

yzqzss
Copy link
Contributor

@yzqzss yzqzss commented Nov 9, 2024 •
edited
Loading

This PR is based on #155

  • Introduce lax parsing mode, so that we can get URLs from unbalanced or malformed XML.
  • Return parsed URLs instead of nil when an error occurs.
  • Replace TestXMLBodyReadError test with TestXMLBodySyntaxEOFError.

@yzqzss yzqzss force-pushed the better-xml-parse branch 2 times, most recently from 163e2f0 to 0482f25 Compare November 9, 2024 18:52
@yzqzss yzqzss marked this pull request as draft November 9, 2024 18:54
@yzqzss yzqzss marked this pull request as ready for review November 12, 2024 03:21
CorentinB
CorentinB approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@CorentinB CorentinB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CorentinB CorentinB merged commit 5719f94 into internetarchive:main Nov 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CorentinB CorentinB CorentinB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yzqzss @CorentinB