[DRAFT] Config Parser #282
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rged methods parse_pipeline and parse_step into one function build_from_config
* add slurm template script * add eurac slurm script for testing * fix some linting errors * add contributors * make script class based * add code for running script * fix more linting errors * move slurm scripts into src and add use-case specific script * rename slurmscript class * add argparser * create runall methods * fix import order * add builder for tutorial * make parser more general * add logic for disabling running script * add function for generating identifier * fix linting errors * make runall work for eurac * fix merge conflicts * some code clean up * small adjustments to make it work for the EURAC case * add implementation for virgo use case * add slurm_scripts/ to gitignore * add ability to override training command in config file * update std_out and err_out automatically * add auto std_out for real this time * make slurm script for scaling test * fix linting errors * add separate file for generic slurm script maker and small changes * fix linting errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The main contribution of this PR is the change from the old ConfigParser (which was based on jsonargparse) to a new one, based on hydra. The advantage of this change is that error messages that arise during execution of the pipeline were often not visible in the error message given out by the jsonargparse parser, whereas in hydra they are passed on. This makes debugging much easier. An example of the difference:
If I set the seed in the config file to "small", I get the following outputs from the old parser and the new one, respectively:
Some other changes that were made in the course of this addition:
parse_pipelineandparse_stepinto one function calledbuild_from_config, as they were almost identical after the change