Fix #35 'kubectl logs -f' implemented #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dciangot
reviewed
Dec 10, 2024
There was a problem hiding this comment.
@antoinetran thank you for this huge contribution. It looks very good to me, just find one comment where I need a clarification on the design. Otherwise I think it's good to go
|
I should have put some info in PullRequest instead of issue35:
TODO for later: when doing Ctrl+C to kubectl logs -f, stops following logs for that session. But I don't know how to detect that and react. |
antoinetran
force-pushed
the
fix_issue35_kubectllogsfollow_rebased
branch
from
b0eb432 to
81a4a12
Compare
|
@antoinetran looks like the last commit broke the compilation, can you take a look? |
|
mmm weird... repeating the tests locally shows no problem... maybe they broke on the force push. So, nvm. I'm push this through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement
kubectl logs -fin interlink VK and API side. In case of following parameter set, it will reads and write continuously with a buffer from API to VK.Also improved InterLink internal log, so that a sessionContext (eg:
GetLogs#12345) is created and added in HTTP header, so that we can also follow the HTTP request from VK to API to Plugin with the same id.Related issue :
interTwin-eu/interlink-slurm-plugin#35