Add OpenCL runtime #796
Open
Add OpenCL runtime #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 28, 2024 05:58
|
I know that the PR is still WIP but left some small comments. Mostly about name usage. |
silee2
reviewed
Jun 28, 2024
added 3 commits
July 1, 2024 05:55
Thanks for the comments. I have updated the code now. Those names were copy-pasted from L0 wrapper and I have now changed them accordingly. I have added opencl-runtime for most of the UTs. And I found some of the tests failing. Still working on it... |
|
Removed the "WIP" status and this PR is ready to review. Added additional RUN in UTs for OpenCL runtime.
The error ends up the wrong setting of WG size. L0, Sycl and Ocl have different ways to set the WG size and x/y/x orders. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR still work-in-progress. I have added opencl-runtime in some of the runner tests. It seems to work well. Todo: