Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update patches for PyTorch upstream #1773

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Update patches for PyTorch upstream #1773

merged 2 commits into from
Aug 7, 2024

Conversation

whitneywhtsang
Copy link
Contributor 

Fallback to CPU for XPU FP64 - https://github.com/pytorch/pytorch/pull/126516
Elapsed time - https://github.com/pytorch/pytorch/pull/126456
Device properties - https://github.com/pytorch/pytorch/pull/131738

@whitneywhtsang whitneywhtsang self-assigned this Aug 3, 2024
@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented Aug 3, 2024 •
edited
Loading

Thank you!

Just some warnings: It may not work till we align properties names. And I was also facing some problems with receiving properties, so I had to apply patch. Check these changes out:
pytorch/pytorch@bff2ac5 - receiving properties
pytorch/pytorch@751c782 - name alignment

@whitneywhtsang whitneywhtsang marked this pull request as draft August 3, 2024 23:42
@vlad-penkin vlad-penkin linked an issue Aug 4, 2024 that may be closed by this pull request
[Upstream PyTorch] Update patches for PyTorch upstream #1776
Closed
@whitneywhtsang
Copy link
Contributor Author

Depends on #1788.

@whitneywhtsang
Copy link
Contributor Author

@ZzEeKkAa #1788 is merged. Do we still need any other changes from your branch?

@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented Aug 7, 2024

@whitneywhtsang no. pytorch/pytorch@751c782 was resolved by #1788 and pytorch/pytorch@bff2ac5 was addressed in the PR itself.

@whitneywhtsang whitneywhtsang marked this pull request as ready for review August 7, 2024 19:04
@whitneywhtsang whitneywhtsang enabled auto-merge (squash) August 7, 2024 19:18
@whitneywhtsang whitneywhtsang merged commit 57f09cb into llvm-target Aug 7, 2024
4 checks passed
@whitneywhtsang whitneywhtsang deleted the whitneywhtsang/pytorch branch August 22, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZzEeKkAa ZzEeKkAa ZzEeKkAa approved these changes

@pbchekin pbchekin pbchekin approved these changes

@alexbaden alexbaden Awaiting requested review from alexbaden

@vlad-penkin vlad-penkin Awaiting requested review from vlad-penkin

Assignees

@whitneywhtsang whitneywhtsang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Upstream PyTorch] Update patches for PyTorch upstream
3 participants
@whitneywhtsang @ZzEeKkAa @pbchekin