feature: add support for querying simd16 eu per dss #745
Conversation
Related-To: NEO-12012 Signed-off-by: Mateusz Jablonski <[email protected]>
| @@ -504,9 +511,10 @@ bool IoctlHelperXe::getTopologyDataAndMap(const HardwareInfo &hwInfo, DrmQueryTo | |||
| topologySize -= itemSize; | |||
| dataPtr = ptrOffset(dataPtr, itemSize); | |||
| } | |||
|
|
|||
| receivedEuPerDssInfo |= receivedSimd16EuPerDssInfo; | |||
There was a problem hiding this comment.
why don't you simply add DRM_XE_TOPO_SIMD16_EU_PER_DSS to operate in the same var as DRM_XE_TOPO_SIMD16_EU_PER_DSS? you are not doing anything differently and kernel isn't going to report both. If the kernel reports both in future it actually means it has 2 different types of EUs in that platform, which would be very odd.
There was a problem hiding this comment.
See equivalent change in mesa: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30127/diffs?commit_id=c1cf9678a95d5d48113e0d572cc50f655a58bc8b
| @@ -835,6 +835,61 @@ TEST(IoctlHelperXeTest, givenComputeDssWhenGetTopologyDataAndMapThenResultsAreCo | |||
| } | |||
| } | |||
|
|
|||
| TEST(IoctlHelperXeTest, givenSimd16EuPerDssAndEuPerDssWhenGetTopologyDataAndMapThenPreferSimd16EuPerDss) { | |||
There was a problem hiding this comment.
it's not meant to prefer one vs the other as we don't return both for any platform. For a non-mock test, an assert that this is true would be ok.
| @@ -513,6 +520,7 @@ struct drm_xe_query_topology_mask { | |||
| #define DRM_XE_TOPO_DSS_GEOMETRY (1 << 0) | |||
| #define DRM_XE_TOPO_DSS_COMPUTE (1 << 1) | |||
| #define DRM_XE_TOPO_EU_PER_DSS (1 << 2) | |||
There was a problem hiding this comment.
There are other changes in this header that are already available in drm-next. It's probably easier if you just sync the header with drm-next and add on top this change. This way it won't conflict with future updates.
This is what we have in drm-next:
#define DRM_XE_TOPO_DSS_GEOMETRY 1
#define DRM_XE_TOPO_DSS_COMPUTE 2
#define DRM_XE_TOPO_L3_BANK 3
#define DRM_XE_TOPO_EU_PER_DSS 4
There was a problem hiding this comment.
Also, feel free to commit this once DRM_XE_TOPO_SIMD16_EU_PER_DSS reaches drm-next as per rules in https://docs.kernel.org/gpu/drm-uapi.html:
The kernel patch can only be merged after all the above requirements are met, but it must be merged to either drm-next or drm-misc-next before the userspace patches land. uAPI always flows from the kernel, doing things the other way round risks divergence of the uAPI definitions and header files.
|
covered in dfbad80 |
Related-To: NEO-12012