Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): add git hash in HealthCheckResponse #514

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joremysh
Copy link
Contributor

@joremysh joremysh commented Nov 8, 2024

Because

  • it helps in debugging with the current running version

This commit

  • add git hash in HealthCheckResponse

Copy link

linear bot commented Nov 8, 2024

Copy link

github-actions bot commented Nov 8, 2024

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedNov 8, 2024, 1:30 AM

Copy link
Collaborator

@jvallesm jvallesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As documented in e.g. vdp, this is a fixed response that I don't think we should customise. I don't think adding this will break anything but I'm hesitant if exposing this in the public API (this endpoint doesn't require authentication) is a good idea.

I think the best approach here is including the revision in the pod definition, then accessing it through kubectl or other tools while debugging.

cc @donch1989 perhaps has an opinion here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants