Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(component): remove availableTasks and availableEvents from definition files #948

Closed
wants to merge 2 commits into from
Closed

refactor(component): remove availableTasks and availableEvents from definition files #948

wants to merge 2 commits into from

Conversation

donch1989
Copy link
Member

Because

  • Tasks and events are already defined in tasks.json and events.json, so there is no need to duplicate availableTasks and availableEvents in definition.yaml.

This commit

  • Removes availableTasks and availableEvents from definition files.
  • Uses ordermap to preserve the order of tasks and events.

@linear Linear
Copy link

linear bot commented Dec 25, 2024

INS-6769 migrate remaining components to new Instill Format

@donch1989 donch1989 marked this pull request as draft December 25, 2024 14:26
@donch1989 donch1989 closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeWilliamStrong GeorgeWilliamStrong Awaiting requested review from GeorgeWilliamStrong GeorgeWilliamStrong is a code owner

@jvallesm jvallesm Awaiting requested review from jvallesm jvallesm is a code owner

Assignees
No one assigned
Labels
instill component instill vdp
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donch1989 @droplet-bot