feat(component,video): add task to embed audio to video #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donch1989
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Hi @memoryonrepeat ,
Thanks for implementing this task. Could you add a few basic test cases first?
Thanks.
|
@donch1989 I have added some test cases as well. |
pinglin
changed the title
pinglin
changed the title
donch1989
approved these changes
Dec 19, 2024
memoryonrepeat
requested review from
GeorgeWilliamStrong and
jvallesm
as code owners
donch1989
pushed a commit
that referenced
this pull request
Dec 23, 2024
🤖 I have created a release *beep* *boop* --- ## [0.49.1-beta](v0.49.0-beta...v0.49.1-beta) (2024-12-23) ### Features * **component,video:** add task to embed audio to video ([#939](#939)) ([1aa40c2](1aa40c2)) ### Bug Fixes * **component,github:** fix data structs ([#944](#944)) ([804e56a](804e56a)) * **mod:** update golang.org/x/net module to fix vulnerability issue ([a2db7de](a2db7de)) ### Miscellaneous Chores * release v0.49.1-beta ([51d676d](51d676d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
CC @xiaofei-du @pinglin