Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(blob): add retention when uploading pipeline trigger data #937

Merged
merged 6 commits into from
Dec 13, 2024
Merged

chore(blob): add retention when uploading pipeline trigger data #937

merged 6 commits into from
Dec 13, 2024

Conversation

jvallesm
Copy link
Collaborator

@jvallesm jvallesm commented Dec 13, 2024 •
edited
Loading

Because

  • When generating a public URL for the pipeline data, we were uploading the data with infinite retention.

This commit

  • Refactors the code to fetch the expiration rules for users and how they're passed to the different parts of the code.
  • Leverages this information to set the expiration data when uploading blob data.

@jvallesm jvallesm self-assigned this Dec 13, 2024
@linear Linear
Copy link

linear bot commented Dec 13, 2024

INS-6857 Improvement: add retention when upload blob data in VDP

@jvallesm jvallesm marked this pull request as ready for review December 13, 2024 10:50
@jvallesm jvallesm requested a review from donch1989 as a code owner December 13, 2024 10:50
@jvallesm jvallesm mentioned this pull request Dec 13, 2024
Merged
@jvallesm jvallesm changed the title chore(blob): add retention when uploading pipeline trigger data' chore(blob): add retention when uploading pipeline trigger data Dec 13, 2024
@jvallesm jvallesm merged commit 1f043f6 into main Dec 13, 2024
14 checks passed
@jvallesm jvallesm deleted the jvalles/ins-6857-improvement-add-retention-when-upload-blob-data-in-vdp branch December 13, 2024 15:08
jvallesm added a commit to instill-ai/model-backend that referenced this pull request Dec 14, 2024
@jvallesm
chore(minio): align expiry rules with pipeline-backend (#721)
2bf8ea0 
Because

- instill-ai/pipeline-backend#937 modifies the
  metadata retention interface, allowing clients to fetch both the
  expiration tag and the duration.

This commit

- Align metadata retention implementation with `pipeline-backend`'s.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

Assignees

@jvallesm jvallesm

Labels
instill vdp
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvallesm @droplet-bot