Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(trigger): resolve issue where default value for number cannot be an integer #933

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(trigger): resolve issue where default value for number cannot be an integer #933

merged 1 commit into from
Dec 11, 2024

Conversation

donch1989
Copy link
Member

This commit

  • resolves issue where default value for number cannot be an integer

Note

  • This is a temporary solution. We will improve the conversion between JSON and Instill Format to make the implementation clearer.

@donch1989 donch1989 requested a review from jvallesm as a code owner December 11, 2024 13:26
@linear Linear
Copy link

linear bot commented Dec 11, 2024

INS-7122 [Bug] Optional Value in Variable did not Support Int

@donch1989 donch1989 merged commit 134032a into main Dec 11, 2024
12 checks passed
@donch1989 donch1989 deleted the huitang/ins-7122 branch December 11, 2024 14:00
@droplet-bot droplet-bot mentioned this pull request Dec 11, 2024
Merged
donch1989 pushed a commit that referenced this pull request Dec 11, 2024
@droplet-bot
chore(main): release 0.48.5-beta (#930)
eb84ce3 
🤖 I have created a release *beep* *boop*
---


##
[0.48.5-beta](v0.48.4-beta...v0.48.5-beta)
(2024-12-11)


### Features

* **pinecone:** pinecone batch upsert
([#927](#927))
([398adf9](398adf9))
* **vdp:** upload component input output data
([#923](#923))
([8b6caab](8b6caab))


### Bug Fixes

* **trigger:** add component intermediate data in the trigger
stream/response
([#932](#932))
([2077ae7](2077ae7))
* **trigger:** resolve issue where default value for number cannot be an
integer
([#933](#933))
([134032a](134032a))


### Miscellaneous Chores

* release v0.48.5-beta
([043788d](043788d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvallesm jvallesm Awaiting requested review from jvallesm jvallesm is a code owner

Assignees
No one assigned
Labels
instill vdp
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donch1989 @droplet-bot