Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integration): add create, update, delete connection endpoints #629

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

jvallesm
Copy link
Collaborator

@jvallesm jvallesm commented Aug 30, 2024

Because

  • Users need to create connections before referencing them in pipelines. Also, they need to be able to modify and delete them.

This commit

  • Add connection creation endpoint.

@jvallesm jvallesm self-assigned this Aug 30, 2024
Copy link

linear bot commented Aug 30, 2024

@jvallesm jvallesm force-pushed the jvalles/ins-5959-manipulate-connections branch 8 times, most recently from f668861 to 75692a8 Compare August 30, 2024 11:53
@jvallesm jvallesm force-pushed the jvalles/ins-5959-manipulate-connections branch 2 times, most recently from 4b58177 to ac652bf Compare September 2, 2024 09:47
@jvallesm jvallesm marked this pull request as ready for review September 2, 2024 09:48
Because we were unsafely reusing the previous GORM query, the last
element wasn't being correctly fetched and the page token was incorrect.
@jvallesm jvallesm force-pushed the jvalles/ins-5959-manipulate-connections branch from ac652bf to d324839 Compare September 2, 2024 09:59
@jvallesm jvallesm merged commit b784553 into main Sep 2, 2024
10 of 11 checks passed
@jvallesm jvallesm deleted the jvalles/ins-5959-manipulate-connections branch September 2, 2024 10:13
donch1989 pushed a commit to instill-ai/instill-core that referenced this pull request Sep 5, 2024
Because

- A dependency on the `xk6` SQL plugin was introduced in
instill-ai/pipeline-backend#629

This commit

- Builds container for integration tests with `xk6` build + SQL plugin
- Removes unnecessary `K6_VERSION` injection to backend images (tests
are run from this repo's `Dockerfile`)

---------

Co-authored-by: Ping-Lin Chang <[email protected]>
jvallesm pushed a commit that referenced this pull request Sep 10, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.38.0-beta](v0.37.0-beta...v0.38.0-beta)
(2024-09-10)


### Features

* add endpoints to read integrations
([#611](#611))
([9be491b](9be491b))
* **integration:** add create, update, delete connection endpoints
([#629](#629))
([b784553](b784553))
* **integration:** add delete and update connection endpoints
([#636](#636))
([b28db2c](b28db2c))
* **integration:** add GetConnection endpoint
([#633](#633))
([0f4e9ca](0f4e9ca))
* **integration:** add ListNamespaceConnections endpoint
([#635](#635))
([404621a](404621a))
* **integration:** list pipeline IDs by connection reference
([#642](#642))
([0c398fe](0c398fe))
* **integration:** reference connections in pipelines
([#638](#638))
([21fcbdb](21fcbdb))
* **run:** capture component run error for run logging
([#639](#639))
([1492214](1492214))


### Bug Fixes

* fix duplicated metric datapoint
([#645](#645))
([c93cf23](c93cf23))
* fix memory leak
([b97ba80](b97ba80))
* fix nil-check
([a86722f](a86722f))
* remove goroutine in ConvertPipelinesToPB
([2d15fbe](2d15fbe))
* reset the preset pipeline sharing setting
([#643](#643))
([1ca23ac](1ca23ac))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: 👋 Done
Development

Successfully merging this pull request may close these issues.

2 participants