Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(service): improve the data validation and its error handling #291

Conversation

donch1989
Copy link
Member

Because

  • We didn't handle the data validation well. We need to validate pipeline input and component input/output data and return proper error messages

This commit

  • Improve the data validation and its error handling

Copy link

linear bot commented Nov 8, 2023

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (f8dac09) 0.00% compared to head (593318c) 0.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main    #291    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files          7       7            
  Lines       2128    2024   -104     
======================================
+ Misses      2128    2024   -104     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/service/state.go 0.00% <ø> (ø)
pkg/service/validator.go 0.00% <ø> (ø)
pkg/service/openapi.go 0.00% <0.00%> (ø)
pkg/service/service.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donch1989 donch1989 merged commit a1b561f into main Nov 8, 2023
12 checks passed
@donch1989 donch1989 deleted the huitang/ins-2534-improve-error-message-for-pipeline-trigger-endpoint branch November 8, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants