Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pipeline): update start operator flows #290

Merged

Conversation

donch1989
Copy link
Member

Because

  • we'd like to refactor start operator so that it has a JSON-schema structure similar to other components.
  • we should use json encoded string in form-data

This commit

  • refactor start operator to use instillAcceptFormats
  • update corresponding OpenAPI generator

Copy link

linear bot commented Nov 6, 2023

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (f8dac09) 0.00% compared to head (fb847ea) 0.00%.

Additional details and impacted files
@@          Coverage Diff           @@
##            main    instill-ai/community#290    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files          7       7            
  Lines       2128    2004   -124     
======================================
+ Misses      2128    2004   -124     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/service/openapi.go 0.00% <0.00%> (ø)
pkg/service/service.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

return fmt.Errorf("%s should be a array", key)
}
sch, err := jsonschema.CompileString("", string(metadata))
sch.Location = ""

Check warning

Code scanning / CodeQL

Missing error check Warning

sch
may be nil at this dereference because
err
may not have been checked.
@donch1989 donch1989 merged commit 205296e into main Nov 6, 2023
11 checks passed
@donch1989 donch1989 deleted the huitang/ins-2519-update-op-start-flows-in-pipeline-backend branch November 6, 2023 16:35
@donch1989
Copy link
Member Author

related to instill-ai/instill-core#574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants