Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(minio): use common miniox #692

Merged
merged 1 commit into from
Sep 24, 2024
Merged

chore(minio): use common miniox #692

merged 1 commit into from
Sep 24, 2024

Conversation

joremysh
Copy link
Contributor

@joremysh joremysh commented Sep 23, 2024 •
edited
Loading

Because

  • it's easier to maintain code by extracting the duplicated functions and referencing it

This commit

  • import miniox from x package

@linear Linear
Copy link

linear bot commented Sep 23, 2024

INS-6273 unit tests for model backend

@joremysh joremysh force-pushed the jeremy/ins-6273-unit-tests-for-model-backend branch 2 times, most recently from 70449a2 to 2486c2e Compare September 24, 2024 07:20
@joremysh joremysh force-pushed the jeremy/ins-6273-unit-tests-for-model-backend branch from 2486c2e to fdad6c9 Compare September 24, 2024 07:41
@joremysh joremysh merged commit 19816ab into main Sep 24, 2024
11 checks passed
@joremysh joremysh deleted the jeremy/ins-6273-unit-tests-for-model-backend branch September 24, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
instill model
Projects
No open projects
🔮 Instill Core
Status: 🚧 Planned
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joremysh @droplet-bot