Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): switch to minimock and add tests #687

Merged
merged 3 commits into from
Sep 14, 2024
Merged

fix(test): switch to minimock and add tests #687

merged 3 commits into from
Sep 14, 2024

Conversation

joremysh
Copy link
Contributor

@joremysh joremysh commented Sep 13, 2024 •
edited
Loading

Because

  • align with pipeline and use same mock package

This commit

  • update mocks and add repo test

@linear Linear
Copy link

linear bot commented Sep 13, 2024

INS-6273 unit tests for model backend

@joremysh joremysh force-pushed the jeremy/ins-6273-unit-tests-for-model-backend branch from f79d70e to f44ef11 Compare September 14, 2024 01:18
@joremysh joremysh force-pushed the jeremy/ins-6273-unit-tests-for-model-backend branch from f44ef11 to 297deed Compare September 14, 2024 02:44
@joremysh joremysh force-pushed the jeremy/ins-6273-unit-tests-for-model-backend branch from 297deed to fb95533 Compare September 14, 2024 02:45
@joremysh joremysh changed the title chore(minio): rename import to recognize external & internal packages fix(test): switch to minimock and add tests Sep 14, 2024
@joremysh joremysh marked this pull request as ready for review September 14, 2024 03:00
@joremysh joremysh merged commit 141da9d into main Sep 14, 2024
13 checks passed
@joremysh joremysh deleted the jeremy/ins-6273-unit-tests-for-model-backend branch September 14, 2024 03:00
@droplet-bot droplet-bot mentioned this pull request Sep 14, 2024
Merged
heiruwu pushed a commit that referenced this pull request Oct 8, 2024
@droplet-bot
chore(main): release 0.30.2-alpha (#691)
01e2f9f 
🤖 I have created a release *beep* *boop*
---


##
[0.30.2-alpha](v0.30.1-alpha...v0.30.2-alpha)
(2024-10-01)


### Bug Fixes

* **test:** switch to minimock and add tests
([#687](#687))
([141da9d](141da9d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@droplet-bot droplet-bot mentioned this pull request Oct 8, 2024
Merged
heiruwu pushed a commit that referenced this pull request Oct 8, 2024
@droplet-bot
chore(main): release 0.30.2-alpha (#694)
6d13dfa 
🤖 I have created a release *beep* *boop*
---


##
[0.30.2-alpha](v0.30.1-alpha...v0.30.2-alpha)
(2024-10-08)


### Bug Fixes

* **minio:** fix nil logger causing panic
([ef9645e](ef9645e))
* **test:** switch to minimock and add tests
([#687](#687))
([141da9d](141da9d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
instill model
Projects
No open projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joremysh @droplet-bot