Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflow): update github action default token #442

Conversation

Sarthak-instill
Copy link
Member

@Sarthak-instill Sarthak-instill commented Oct 26, 2023

Because

  • we need to update github action default token and remove docker hub login.

This commit

  • update github action default token

@linear
Copy link

linear bot commented Oct 26, 2023

INS-2412 For public repo's PR GA workflow, we don’t need to log in to our Docker Hub.

pinglin said:

engineering For our public repos’ pull request GA workflow, we don’t need to log in to our Docker Hub. The GA secret can’t be exposed to a forked repo anyway. Also, for Codecov GA workflow, we will need to use the GitHub default token here so the pull request from a forked repo branch can also trigger the Codecov GA workflow. sarthak.gupta Can you help update the logic for all repos. Thanks.

<https://github.com/instill-ai/model-backend/blob/main/.github/workflows/coverage.yml | coverage.yml>

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32bffea) 1.04% compared to head (cebf07b) 1.04%.
Report is 2 commits behind head on main.

❗ Current head cebf07b differs from pull request most recent head 98901ad. Consider uploading reports for the commit 98901ad to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #442   +/-   ##
=====================================
  Coverage   1.04%   1.04%           
=====================================
  Files         10      10           
  Lines       5373    5373           
=====================================
  Hits          56      56           
  Misses      5309    5309           
  Partials       8       8           
Flag Coverage Δ
unittests 1.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sarthak-instill Sarthak-instill force-pushed the sarthakgupta/ins-2412-for-public-repos-pr-ga-workflow-we-dont-need-to-log-in-to branch from cebf07b to 98901ad Compare October 26, 2023 19:03
@Sarthak-instill Sarthak-instill changed the title ci(workflow): add condition for docker hub login to fork PR ci(workflow): update github action default token Oct 26, 2023
Copy link
Member

@pinglin pinglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinglin pinglin merged commit d3ddf0c into main Oct 26, 2023
10 checks passed
@pinglin pinglin deleted the sarthakgupta/ins-2412-for-public-repos-pr-ga-workflow-we-dont-need-to-log-in-to branch October 26, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants