Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(logging): reduce unnecessary log emission #428

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Oct 11, 2023

Because

  • Currently backends in Instill Base Instill VDP and Instill Model will emit a huge amount of logs with level Info, which can overwhelm stdout

This commit

  • Refactor grpc logger verbosity and bypass successful private function calls

closes instill-ai/instill-core#610

@linear
Copy link

linear bot commented Oct 11, 2023

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f4d3a82) 1.04% compared to head (7dd1f56) 1.04%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    instill-ai/community#428   +/-   ##
=====================================
  Coverage   1.04%   1.04%           
=====================================
  Files         10      10           
  Lines       5360    5360           
=====================================
  Hits          56      56           
  Misses      5296    5296           
  Partials       8       8           
Flag Coverage Δ
unittests 1.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heiruwu heiruwu changed the title refactor(log): reduce unnecessary log emission refactor(logging): reduce unnecessary log emission Oct 11, 2023
@heiruwu heiruwu merged commit 477a076 into main Oct 11, 2023
14 checks passed
@heiruwu heiruwu deleted the heiru/ins-2312-reduce-log-emission-from-model-backend branch October 11, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INS-2258] [Improvement] Reduce unnecessary log emission from backends
2 participants