Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflows): refactor integration tests #1086

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

pinglin
Copy link
Member

@pinglin pinglin commented Sep 4, 2024

Because

  • we can safely run the integration tests on only Linux because instill-core relies on Docker Desktop on MacOS.
  • as the codebase continues to evolve the timeout 60 for the integration tests is no longer enough

This commit

  • remove integration tests for MacOS
  • increase timeout to 120
  • upgrade to actions/checkout@v4 to address the warning:
  • disable image build in integration-test
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

@donch1989 donch1989 force-pushed the pinglin/ci-workflow-refactor branch 2 times, most recently from c09817d to 74b62d1 Compare September 6, 2024 14:58
@donch1989 donch1989 force-pushed the pinglin/ci-workflow-refactor branch 2 times, most recently from ce581ae to 633bf0e Compare September 6, 2024 17:25
@donch1989 donch1989 force-pushed the pinglin/ci-workflow-refactor branch from 633bf0e to c0054ef Compare September 6, 2024 17:37
@donch1989 donch1989 merged commit d227481 into main Sep 6, 2024
11 checks passed
@donch1989 donch1989 deleted the pinglin/ci-workflow-refactor branch September 6, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: 👋 Done
Development

Successfully merging this pull request may close these issues.

3 participants