Skip to content

Commit

Permalink
Merge pull request #78 from insideapp-oss/develop
Browse files Browse the repository at this point in the history
Release 0.4.0
  • Loading branch information
kuhnroyal authored Sep 2, 2021
2 parents 091d221 + 33aee15 commit d14c070
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/stale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
close-issues:
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v3
- uses: actions/stale@v4.0.0
with:
days-before-issue-stale: 90
days-before-issue-close: 14
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@ Changelog is available [here](https://github.com/insideapp-oss/sonar-flutter/blo

### Flutter SDK

Install Flutter as explained on the official documentaiton page.
Install Flutter as explained on the official documentation page.

[Installation instructions](https://flutter.dev/docs/get-started/install)

### Dart

Dart is downloaded by the Flutter SDK in **$FLUTTER_HOME/bin/cache/dart-sdk**, however command lines are not on the path by default (dartanalyzer must be on the path).

It is recommanded to install Dart SDK separately as explained here : [Install the Dart SDK](https://dart.dev/get-dart) for more reliability in a CI/CD environement.
It is recommended to install Dart SDK separately as explained here : [Install the Dart SDK](https://dart.dev/get-dart) for more reliability in a CI/CD environment.

### sonar-scanner (requires Java)

Expand Down
2 changes: 1 addition & 1 deletion dart-lang/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<parent>
<artifactId>sonar-flutter</artifactId>
<groupId>fr.insideapp.sonarqube</groupId>
<version>0.3.2</version>
<version>0.4.0</version>
</parent>
<modelVersion>4.0.0</modelVersion>

Expand Down
10 changes: 4 additions & 6 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
<parent>
<groupId>org.sonarsource.parent</groupId>
<artifactId>parent</artifactId>
<version>52</version>
<version>59.0.29</version>
</parent>

<groupId>fr.insideapp.sonarqube</groupId>
<artifactId>sonar-flutter</artifactId>
<version>0.3.2</version>
<version>0.4.0</version>

<packaging>pom</packaging>

Expand All @@ -31,7 +31,7 @@
<licenses>
<license>
<name>GNU LGPL 3</name>
<url>http://www.gnu.org/licenses/lgpl.txt</url>
<url>https://www.gnu.org/licenses/lgpl-3.0.txt</url>
<distribution>repo</distribution>
</license>
</licenses>
Expand All @@ -58,8 +58,6 @@

<maven.test.redirectTestOutputToFile>true</maven.test.redirectTestOutputToFile>

<sonarQubeMinVersion>6.7</sonarQubeMinVersion>

<assertj.version>3.5.2</assertj.version>
<guava.version>17.0</guava.version>
<junit.version>4.10</junit.version>
Expand All @@ -70,7 +68,7 @@
<sonar-orchestrator.version>3.22.0.1791</sonar-orchestrator.version>
<sonarlint.version>4.0.0.2052</sonarlint.version>
<sslr.version>1.23</sslr.version>
<sslr-squid-bridge.version>2.6.1</sslr-squid-bridge.version>
<sslr-squid-bridge.version>2.7.1.392</sslr-squid-bridge.version>
<ant.version>1.6</ant.version>
<analyzer-commons.version>1.10.2.456</analyzer-commons.version>
<assertj.version>3.5.2</assertj.version>
Expand Down
7 changes: 6 additions & 1 deletion scripts/updateDartAnalyzerRules.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,12 @@ def assignType(key) {
}

if (grandParentNode.name.text() == 'Reliability') {
return "BUG"

// See https://github.com/insideapp-oss/sonar-flutter/pull/32
if (!ruleNode.name.text().startsWith('prefer_final')) {
return "BUG"
}

}
}

Expand Down
4 changes: 2 additions & 2 deletions sonar-flutter-plugin/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<parent>
<artifactId>sonar-flutter</artifactId>
<groupId>fr.insideapp.sonarqube</groupId>
<version>0.3.2</version>
<version>0.4.0</version>
</parent>
<modelVersion>4.0.0</modelVersion>

Expand All @@ -17,7 +17,7 @@
<dependency>
<groupId>fr.insideapp.sonarqube</groupId>
<artifactId>dart-lang</artifactId>
<version>0.3.2</version>
<version>0.4.0</version>
</dependency>

</dependencies>
Expand Down

0 comments on commit d14c070

Please sign in to comment.