Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove CP_SRC UDC #127

Merged
merged 1 commit into from
Dec 8, 2023
Merged

chore: remove CP_SRC UDC #127

merged 1 commit into from
Dec 8, 2023

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented Dec 8, 2023

Description

Remove CP_SRC UDC is a redundant command that could be replaced by the common COPY command.

Related Issue(s)

e.g., Closes #110

Description of Changes

  • Removed CP_SRC UDC
  • Removed cspell-test as it won't be used by other dependencies.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem added the ci/cd CI/CD Fixes or Improvements. label Dec 8, 2023
@apskhem apskhem requested review from stevenj and Mr-Leshiy December 8, 2023 08:37
@apskhem apskhem self-assigned this Dec 8, 2023
@apskhem apskhem linked an issue Dec 8, 2023 that may be closed by this pull request
🛠️ [TASK] : Remove CP_SRC UDC #110
Closed
Mr-Leshiy
Mr-Leshiy approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit 398a697 into master Dec 8, 2023
44 checks passed
@Mr-Leshiy Mr-Leshiy deleted the chore/remove-cp-src branch December 8, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mr-Leshiy Mr-Leshiy Mr-Leshiy approved these changes

@stevenj stevenj Awaiting requested review from stevenj

Assignees

@apskhem apskhem

Labels
ci/cd CI/CD Fixes or Improvements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Remove CP_SRC UDC
2 participants
@apskhem @Mr-Leshiy