Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/named fn params #798

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/named fn params #798

wants to merge 2 commits into from

Conversation

jpwilliams
Copy link
Member

Summary

Broadens the types of step.run() to better recognize Function as callable, therefore making the generic and allowing Parameters<TFn> to extract correctly.

// This should now work
step.run("", function named() {});

Checklist

  • Added a docs PR that references this PR N/A Bug fix
  • Added unit/integration tests
  • Added changesets if applicable

@jpwilliams jpwilliams added Bug Something isn't working prerelease/inngest Create snapshot releases for a PR for the "inngest" package. labels Jan 9, 2025
@jpwilliams jpwilliams self-assigned this Jan 9, 2025
Copy link

changeset-bot bot commented Jan 9, 2025

⚠️ No Changeset found

Latest commit: 5b05131

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@inngest-release-bot inngest-release-bot added the 📦 inngest Affects the `inngest` package label Jan 9, 2025
@inngest-release-bot
Copy link
Collaborator

A user has added the prerelease/inngest label, so this PR will be published to npm with the tag pr-798. It will be updated with the latest changes as you push commits to this PR.

You can install this prerelease version with:

npm install inngest@pr-798

The last release was built and published from 5b05131.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working 📦 inngest Affects the `inngest` package prerelease/inngest Create snapshot releases for a PR for the "inngest" package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants