Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: waitForEvent data parsing #346

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Conversation

jpwilliams
Copy link
Member

@jpwilliams jpwilliams commented Oct 6, 2023

Summary

  • Fixes waitForEvent dropping some data when resolving with an event
  • Fixes steps fetched via the API not being parsed for v0 runs

Checklist

  • Added a docs PR that references this PR
  • Added unit/integration tests
  • Added changesets if applicable

@jpwilliams jpwilliams added the Bug Something isn't working label Oct 6, 2023
@jpwilliams jpwilliams requested review from tonyhb and darwin67 October 6, 2023 10:23
@jpwilliams jpwilliams self-assigned this Oct 6, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 6, 2023

🦋 Changeset detected

Latest commit: 3171f82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
inngest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jpwilliams jpwilliams changed the title Hotfix/incoming data parsing Hotfix: waitForEvent data parsing Oct 6, 2023
@jpwilliams jpwilliams merged commit c14bbb3 into main Oct 6, 2023
22 checks passed
@jpwilliams jpwilliams deleted the hotfix/incoming-data-parsing branch October 6, 2023 10:56
jpwilliams pushed a commit that referenced this pull request Oct 6, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## [email protected]

### Patch Changes

- [#348](#348)
[`ebb245f`](ebb245f)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix
`"inngest/next"` types not inferring from `defineProperties`

- [#346](#346)
[`c14bbb3`](c14bbb3)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix
`waitForEvent` potentially dropping some fields when being parsed

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants