fix(tabs): make tab panels focusable #2281
Conversation
gerjanvangeest
requested review from
tlouisse,
narzac,
Knorgias and
okadurin
as code owners
🦋 Changeset detectedLatest commit: d493f6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| * https://www.w3.org/WAI/ARIA/apg/patterns/tabs/examples/tabs-automatic/ | ||
| */ | ||
| if (!el.hasAttribute('tabindex')) { | ||
| el.setAttribute('tabindex', '0'); |
There was a problem hiding this comment.
maybe we can also clean up on cleanButton?
(where it's usually better to restore initial state (could be stored in a Weakmap) then a regardless removal)
There was a problem hiding this comment.
The cleanButton() function makes sure the button and panels are "clean" before we put our own id, role and event listeners on it.
It is not a restore afterwards.
There was a problem hiding this comment.
I think it's called here on slot change:
Basically we say here: "whatever content is now available in the slot (it might be different from the contents that were previously inside the slot that we already altered), make sure that we leave the elements we altered in a clean state (their initial state)"
There was a problem hiding this comment.
Created an issue for doing this consistently throughout the codebase: #2295
What I did