New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(code): Vote extensions v2 #775

Draft

romac wants to merge 2 commits into main from romac/vote-extensions-v2

Member

romac commented Jan 16, 2025 •

edited

Loading

Closes: #717

⚠️ WIP ⚠️

TODO

Send own + received vote extensions up to the app

Questions

Should the app generate a plain Extension and then have it signed by consensus or generate a SignedExtension directly?

PR author checklist

For all contributors

Reference GitHub issue
Ensure PR title follows the conventional commits spec

For external contributors

Maintainers of Malachite are allowed to push changes to the branch

romac added 2 commits

January 16, 2025 12:20


          Add ExtendVote effect

bb60eae


          Remove vote extension from proposal types

3d1f185

romac added the work in progress label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ancazamfir Awaiting requested review from ancazamfir ancazamfir will be requested when the pull request is marked ready for review ancazamfir is a code owner

greg-szabo Awaiting requested review from greg-szabo greg-szabo will be requested when the pull request is marked ready for review greg-szabo is a code owner

At least 1 approving review is required to merge this pull request.

Labels

work in progress