Fix #28 Follow cursor in Verovio

infojunkie · May 26, 2023 · 1d2c9b5 · 1d2c9b5
1 parent 1859dec
commit 1d2c9b5
Show file tree

Hide file tree

Showing 6 changed files with 28 additions and 11 deletions.
diff --git a/dist/musicxml-player.esm.js b/dist/musicxml-player.esm.js
@@ -1,5 +1,5 @@
 /*!
- * musicxml-player v0.7.3
+ * musicxml-player v0.8.0
  * (c) Karim Ratib <[email protected]> (https://github.com/infojunkie)
  * Released under the GPL-3.0-only License.
  */
@@ -12582,7 +12582,7 @@ class WebAudioFontOutput {
 }
 
 var name = "musicxml-player";
-var version = "0.7.3";
+var version = "0.8.0";
 var description = "A simple JavaScript component that loads and plays MusicXML files in the browser using Web Audio and Web MIDI.";
 var main = "dist/musicxml-player.esm.js";
 var type = "module";
@@ -15383,8 +15383,17 @@ class VerovioRenderer {
             this._notes = notes;
             this._notes.forEach((noteid) => {
                 const note = document.getElementById(noteid);
-                note === null || note === void 0 ? void 0 : note.setAttribute('fill', '#c00');
-                note === null || note === void 0 ? void 0 : note.setAttribute('stroke', '#c00');
+                if (!note)
+                    return;
+                note.setAttribute('fill', '#c00');
+                note.setAttribute('stroke', '#c00');
+                if (this._options.breaks === 'none') {
+                    note.scrollIntoView({ 'behavior': 'auto', 'inline': 'center' });
+                }
+                else {
+                    const system = note.closest('.system');
+                    system === null || system === void 0 ? void 0 : system.scrollIntoView({ 'behavior': 'auto', 'block': 'center' });
+                }
             });
         }
     }

diff --git a/dist/musicxml-player.esm.js.map b/dist/musicxml-player.esm.js.map
diff --git a/dist/types/VerovioRenderer.d.ts.map b/dist/types/VerovioRenderer.d.ts.map
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "musicxml-player",
-  "version": "0.7.3",
+  "version": "0.8.0",
   "description": "A simple JavaScript component that loads and plays MusicXML files in the browser using Web Audio and Web MIDI.",
   "main": "dist/musicxml-player.esm.js",
   "type": "module",

diff --git a/src/VerovioRenderer.ts b/src/VerovioRenderer.ts
@@ -113,8 +113,16 @@ export class VerovioRenderer implements ISheetRenderer {
       this._notes = notes;
       this._notes.forEach((noteid) => {
         const note = document.getElementById(noteid);
-        note?.setAttribute('fill', '#c00');
-        note?.setAttribute('stroke', '#c00');
+        if (!note) return;
+        note.setAttribute('fill', '#c00');
+        note.setAttribute('stroke', '#c00');
+        if (this._options.breaks === 'none') {
+          note.scrollIntoView({ 'behavior': 'auto', 'inline': 'center' });
+        }
+        else {
+          const system = note.closest('.system');
+          system?.scrollIntoView({ 'behavior': 'auto', 'block': 'center' });
+        }
       });
     }
   }