Skip to content

Commit

Permalink
Remove unnecessary bank select
Browse files Browse the repository at this point in the history
  • Loading branch information
infojunkie committed Dec 8, 2024
1 parent e4ebbf3 commit 4fb7d4c
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 7 deletions.
2 changes: 1 addition & 1 deletion build/libmusicxml.sef.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion build/mscx.sef.json

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "musicxml-mscx",
"version": "0.4.1",
"version": "0.4.2",
"description": "MuseScore to MusicXML converter and back.",
"author": "Karim Ratib <[email protected]> (https://github.com/infojunkie)",
"license": "GPL-3.0-only",
Expand Down
2 changes: 0 additions & 2 deletions src/mscx.xsl
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,6 @@
</xsl:if>
<xsl:copy-of select="$instruments/museScore/Articulation"/>
<Channel>
<controller ctrl="0"><xsl:attribute name="value" select="floor(number((midi-instrument/midi-bank[1], 128)[1]) div 128)"/></controller>
<controller ctrl="32"><xsl:attribute name="value" select="number((midi-instrument/midi-bank[1], 0)[1]) mod 128"/></controller>
<program><xsl:attribute name="value" select="number((midi-instrument/midi-program[1], 1)[1]) - 1"/></program>
<controller ctrl="7"><xsl:attribute name="value" select="floor(number((midi-instrument/volume[1], 80)[1]) * 127 div 100)"/></controller>
<controller ctrl="10"><xsl:attribute name="value" select="floor((number((midi-instrument/pan[1], 0)[1]) + 180) * 127 div 360)"/></controller>
Expand Down

0 comments on commit 4fb7d4c

Please sign in to comment.