Go Frontend #130
Merged
Go Frontend #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I never liked port_driver.c anyway
Not working correctly yet
Conflicts: c_src/port_driver.c
Also we don't need bash
…olegdb into feature/go-frontend
| @@ -1,620 +0,0 @@ | |||
| /* | |||
| * This is where the magic happens. | |||
|
One question about the go frontend: The erlang one guranteed some thread safety by ensuring that operations only happened one at a time. Does the go version do something similar? How do concurrent requests work? |
Conflicts: c_src/port_driver.c run_tests.sh
|
🐼 |
qpfiffer
added a commit
that referenced
this pull request
Nov 26, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're at feature-parity with the Erlang frontend I might as well open the PR.
For the current status on the frontend development, check #124
Some API were changed, I changed the docs accordingly and updated all the examples, please double check them to see if I made any typos (plz eng not my nat language xoxoxo etc.)
Travis is being a bitch, it works fine in Buildbot, @kyleterry pls do sumthin.