-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.fritzbox): Make inputs.fritzbox an internal plugin #16390
Open
hdecarne
wants to merge
12
commits into
influxdata:master
Choose a base branch
from
hdecarne:fritzbox-plugin
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,296
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraf-tiger
bot
added
feat
Improvement on an existing feature such as adding a new setting/mode to an existing plugin
plugin/input
1. Request for new input plugins 2. Issues/PRs that are related to input plugins
labels
Jan 10, 2025
hdecarne
changed the title
feat(inputs.fritzbox): Initial implementation
feat(inputs.fritzbox): Make inputs.fritzbox an internal plugin
Jan 10, 2025
Hipska
suggested changes
Jan 15, 2025
@Hipska I have reworked the plugin accordingly (see comments/commits for details). Please let me know if there are additional issues. |
Hipska
suggested changes
Jan 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added another round
@Hipska, thanks for the detailed review. I have reworked the plugin's configuration interface overall as suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feat
Improvement on an existing feature such as adding a new setting/mode to an existing plugin
plugin/input
1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR provides the inputs.fritzbox plugin for collecting statistics from AVM devices (routers, repeaters, ...). It uses the device's TR-064 interfaces to retrieve the status.
I previously contributed this plugin as an external one. As part of the latest reworks I also converted it into an internal one.
Checklist
Related issues
resolves #16389