chore: use community maintained golang-jwt #21934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dgrijalva/jwt-go project is no longer maintained[1] and they have transferred ownership to golang-jwt/jwt[2][3][4]. We should move to the supported golang-jwt/jwt. The following was performed: 1. update services/httpd/handler*.go to import golang-jwt/jwt 2. revert testcase string comparison changes from 225bcec (back to v3) 2. go mod edit -require github.com/golang-jwt/[email protected]+incompatible 3. go mod edit -droprequire github.com/dgrijalva/jwt-go 4. go mod tidy # see note 5. go clean ./... && go build ./... 6. go test ./... Note: 'go mod tidy' had unrelated changes (perhaps it wasn't run in recent commits) so I removed the unrelated delta to keep this PR focused on the dgrijalva/jwt-go to golang-jwt/jwt changes. References: [1] dgrijalva/jwt-go#462 [2] dgrijalva/jwt-go#463 [3] https://github.com/dgrijalva/jwt-go/blob/master/README.md [4] https://github.com/golang-jwt/jwt [5] influxdata#21926
jdstrand
force-pushed
the
jdstrand/update-jwt-go-master1.x
branch
from
2241ee3 to
b5e9edb
Compare
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21926
The dgrijalva/jwt-go project is no longer maintained[1] and they have
transferred ownership to golang-jwt/jwt[2][3][4]. We should move to the
supported golang-jwt/jwt.
The following was performed:
Note: 'go mod tidy' had unrelated changes (perhaps it wasn't run in
recent commits) so I removed the unrelated delta to keep this PR focused
on the dgrijalva/jwt-go to golang-jwt/jwt changes.
References:
[1] dgrijalva/jwt-go#462
[2] dgrijalva/jwt-go#463
[3] https://github.com/dgrijalva/jwt-go/blob/master/README.md
[4] https://github.com/golang-jwt/jwt
[5] #21926