-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue v1/add singe model null refs #849
base: release/v1
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff in PureCollection.ts is quite big because of the prettier changes. I marked all real changes there.
The other relevant change is in utils.ts
@@ -443,7 +491,9 @@ export class PureCollection { | |||
|
|||
const existingModel = this.findOne(modelType, modelId); | |||
if (existingModel) { | |||
updateModel(existingModel, model); | |||
if (!insertOnly) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has changed
if (model instanceof Array) { | ||
model.forEach((item) => { | ||
this.__insertModel(item, type, id); | ||
this.__insertModel(item, type, id, insertOnly); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has changed
const modelInstance = upsertModel(data, type, this); | ||
this.__insertModel(modelInstance, type); | ||
this.__insertModel(modelInstance, type, undefined, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has changed
916a435
to
88c96a4
Compare
da3c137
to
de01aa4
Compare
8fb747e
to
de01aa4
Compare
Please select all that apply:
Please describe the differences between the current and new behavior